Repository navigation
232 revises resize/zoom - #511
Conversation
hjmjohnson
left a comment
There was a problem hiding this comment.
This is looking good to me. Very nice removal of 1 dependency.
|
@Nic-Ma this is ready for review, please help run the integration tests locally, thanks! |
|
@wyli, Could I run the integration testing so that this PR may be merged? If so, please provide instructions of what you need. |
thanks for asking @hjmjohnson, would be great to run the master branch-only tests |
|
@wyli I am getting two failures
|
|
@wyli : FYI: The master branch also fails at git hash |
Hi @hjmjohnson , Thanks for your help here. |
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me.
And I am wondering why you don't use the AffineTransform to do resize/zoom? I think it can also update the affine matrix.
|
BTW, I ran the |
thank you! |
yes, it's the same logic but nn.functional.interpolate supports more interpolation mode(, and probably faster) |
subtask of #232; fixes #290
Revises zoom/zoomd, resize/resized, randzoom/randzoomd, png_saver to use torch interpolate instead of skimage.transform
Status
ready
Types of changes